MPD MP3 -> Shoutcast streaming (part 2) [UPDATED Sept 15]

August 25, 2008 ericw 16 comments

Update: due to wide-spread changes in the MPD git repository, this patch no longer applies and builds correctly. You can still play with the shout MP3 plugin by cloning my shiny-new git repository at: http://git.musicpd.org/encoded/mpd.git See the comments section below for information about configuration changes. The plugin is currently on the roadmap for the 0.14.0 release, so keep your fingers crossed.

I’ve updated my patch so that it can be applied against the current MPD git repository. Hopefully it will be rolled into MPD for the 0.14.0 release. The patch has been improved to do better configuration-time checking for the lame library. I also found a bug where I wasn’t setting the bit rate properly if constant bit rate was requeted.

I’m hoping to roll this out to Mildred soon.

Here’s the link: 0001-Creation-of-shout_mp3-audio-output-plugin.-Basicall.patch

C, Software mp3, mpd, music

Comments

Leave a comment Trackback

Written by Damian about 2 years ago.

Great patch!! I was waiting for something like this for months!… maybe an entirely year!.

Thanks for your work =) I hope that mpd 0.14 comes with it.

But, Can you provide me with a configuration example of the shout_mp3 plugin?

Thanks again!
Written by ericw about 2 years ago.
The config is basically the same as for “shout”, just change “shout” to “shout_mp3″. See the mpd.conf(5) man page for more info.

I’ll try to paste an example block below, dunno how well it will show up in comments.

audio_output { type "shout_mp3" host "localhost" port "8000" user "source" password "BrGHVVA7" name "mp3 test" mount "/test.mp3" quality "5" format "44100:16:2" public "no" description "MPD MP3 streaming test" genre "In yo face!" }

I should also mention that this config will likely change in 0.14.0. Sorry. :/

e.
Written by Aldibier about 2 years ago.

When I execute the patch, I receive this message, I see some FAILED messages.

[root@localhost mpd-0.13.2]# patch -p1 < ../0001-Creation-of-shout_mp3-audio-output-plugin.-Basicall.patch
patching file configure.ac
Hunk #1 succeeded at 63 with fuzz 1 (offset -8 lines).
Hunk #2 succeeded at 84 with fuzz 1 (offset -3 lines).
Hunk #3 succeeded at 171 (offset -25 lines).
Hunk #4 succeeded at 208 (offset -3 lines).
Hunk #5 succeeded at 340 (offset -28 lines).
Hunk #6 succeeded at 721 (offset -42 lines).
Hunk #7 succeeded at 769 (offset -29 lines).
patching file m4/lame.m4
patching file src/Makefile.am
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED — saving rejects to file src/Makefile.am.rej
patching file src/audio.c
Hunk #1 FAILED at 85.
1 out of 1 hunk FAILED — saving rejects to file src/audio.c.rej
patching file src/audioOutput.h
Hunk #1 FAILED at 109.
1 out of 1 hunk FAILED — saving rejects to file src/audioOutput.h.rej
patching file src/audioOutputs/audioOutput_shout_mp3.c

I send this message because, when I execute the “make” command I receive this message.

checking for mad.h… yes
checking for mad_stream_init in -lmad… yes
./configure: line 24968: syntax error near unexpected token `MPD_LIBS=”$MPD_LIBS $LAME_LIBS”‘
./configure: line 24968: ` AM_PATH_LAME(MPD_LIBS=”$MPD_LIBS $LAME_LIBS” MPD_CFLAGS=”$MPD_CFLAGS $LAME_CFLAGS”,’
make: *** [config.status] Error 2

Posdata: Excuseme my english.
Written by ericw about 1 year ago.

From the command-line you’ve posted, it appears that you’re trying to apply the git patch against the 0.13.2 release. That won’t work. If you have the 0.13.2 sources, be sure to use the patch from my first post (http://kill-0.com/patches/shout_mp3.patch)

e.
Written by Patrik about 1 year ago.

git clone git://git.musicpd.org/normalperson/mpd
wget http://kill-0.com/patches/0001-Creation-of-shout_mp3-audio-output-plugin.-Basicall.patch
cd mpd/
patch -p1 < ../0001-Creation-of-shout_mp3-audio-output-plugin.-Basicall.patch
Hunk #1 succeeded at 74 (offset 3 lines).
Hunk #2 succeeded at 90 (offset 3 lines).
Hunk #3 succeeded at 199 (offset 3 lines).
Hunk #4 succeeded at 214 (offset 3 lines).
Hunk #5 succeeded at 371 (offset 3 lines).
Hunk #6 succeeded at 766 (offset 3 lines).
Hunk #7 succeeded at 801 (offset 3 lines).
…

No errors occur…

./autogen.sh
…

You are now ready to compile MPD
Type “make” to compile MPD
make
…
udioOutputs/audioOutput_shout_mp3.c:53: error: expected specifier-qualifier-list before ‘MpdTag’
audioOutputs/audioOutput_shout_mp3.c: In function ‘newShoutData’:
audioOutputs/audioOutput_shout_mp3.c:73: error: ‘ShoutData’ has no member named ‘tag’
audioOutputs/audioOutput_shout_mp3.c:74: error: ‘ShoutData’ has no member named ‘tagToSend’
audioOutputs/audioOutput_shout_mp3.c:77: error: ‘ShoutData’ has no member named ‘timeout’
audioOutputs/audioOutput_shout_mp3.c:78: error: ‘ShoutData’ has no member named ‘connAttempts’
audioOutputs/audioOutput_shout_mp3.c:79: error: ‘ShoutData’ has no member named ‘lastAttempt’
audioOutputs/audioOutput_shout_mp3.c:80: error: ‘ShoutData’ has no member named ‘audioFormat’
audioOutputs/audioOutput_shout_mp3.c:81: error: ‘ShoutData’ has no member named ‘timer’

and so on. What am I doing wrong?
Written by ericw about 1 year ago.
You did nothing wrong. Unfortunately, normalperson has made a bunch of changes to the git repository since I wrote that patch, and now things don’t compile.

If you want to play with the shout mp3 plugin, you can clone the git repository that normalperson was nice enough to setup for me at: http://git.musicpd.org/encoded/mpd.git

You’ll want to be aware of the following, from the commit log for b5f6593ed4967c9bb9ab74e7dbd695208696e04d:

Configuration for an Ogg stream doesn't change. For an MP3 stream, configuration is the same as Ogg, with two exceptions. First, you must specify the optional "encoding" parameter, which should be set to "mp3". See mpd.conf(5) for more details. Second, the "quality" parameter is reversed for LAME, such that 1 is high quality for LAME, whereas 10 is high quality for Ogg.

As I said, normalperson (and others), have made a number of improvements since my patches, but that link should let you play until my patches get picked up (which it seems they will).
Written by Patrik about 1 year ago.

Hi again!
Thanks for a fast answer. That helped out, now Mpd is streaming mp3 with help of Icecast which makes my NSLU2-player more happy.
The patch failed at a few points, but everything is working anyway.
Good luck with getting the patch included and thanks for a good patch!
Written by Lindylex about 1 year ago.

ericw, thanks for the help and you providing this patch.

http://mo-de.net/d/mpd_with_mp3_streaming.tar.gz

I made .deb and .rpm files of your great work here. Its document pretty well to help newbies install it and get it to work. The focus of the documentation is Debian Sid but should work well for Debian Lenny and Ubuntu.

Thanks, Lindylex
Written by cutgutbeateneaten about 1 year ago.

hi
i have installed mpd 0.14.1 http://packages.debian.org/unstable/sound/mpd and icecast2 on ubuntu 8.04
ogg stream works fine but i can’t get mp3 stream to work. But my ipbox are only able to play mp3streams .Every time i change the encoder at the mpd.conf and restart the mpd I became this

* Starting Music Player Daemon mpd
binding to address for localhost
path_set_fs_charset: fs charset is: UTF-8
reading DB
shout: couldn’t find shout encoder plugin “mp3″
Aborted

i can’t find any thing about the encoder plugin and how to add it
mpd.conf
http://paste.ubuntuusers.de/393989/

maybe someone could help me
Written by ericw about 1 year ago.

It would seem that you don’t have one of the necessary libraries for mp3 output. Looking at http://packages.debian.org/unstable/sound/mpd, I can see that libmp3lame support is not included. This is required for mp3 streaming output.

e.
Written by cutgutbeateneaten about 1 year ago.

i replaced the 0.14.1 with the deb from Lindylex and now it works fine.
thanks
pascal
Written by Chricken about 1 year ago.

Hi,

thanks for your work.
Seems great, but I have a problem:
I removed my MPD 0.14.1 and tried to install Lindylex’ deb.

Got no error:

dpkg -i mpd_0.14.0-1_i386.deb
Selecting previously deselected package mpd.
(Reading database … 23791 files and directories currently installed.)
Unpacking mpd (from mpd_0.14.0-1_i386.deb) …
Setting up mpd (0.14.0-1) …

But nothing seems to have happened.
There is no file written to /etc/init.d and the old one doens’t work anymore.
The file /usr/bin/mpd doesn’t exist and the /etc/mpd.conf hasn’t been rewritten (what I have expected)

While the first attempt of installing I got the message, that some directories could not be deleted. I deleted them by hand and installed again. Maybe, that was an error?

Can you help me out with this problem?
Thanks
Chricken
Written by ericw about 1 year ago.

I don’t really know how Lindylex has the .deb setup, but I would suggest looking for the bin file in the other usual places, /usr/local/bin or /usr/local/mpd/bin. As for the /etc/init.d/ issue, I suspect it would just be a matter of editing it to update the paths of any files that have changed.

I don’t have any contact info for Lindylex unfortunately, but maybe he or she will check back and reply to your comment. Good luck.

e.
Written by Chricken about 1 year ago.

Yeah, that’s it,

the bin has simply been installed to another directory:
/usr/local/bin
Now it all works, finally I got MP3-Output Yeaha

Thanks Buddies
Chricken
Written by lindylex about 7 months ago.

I am so sorry for any confusion. I just checked back these are the only two paths the the .deb would install too.

/usr/bin/mpd
/usr/local/bin/mpd

Once again sorry for the delayed response. I wonder if it would be useful for the admin to have my contact?
Written by lindylex about 7 months ago.

In the /etc/init.d/mpd look for this line at the top and edit it to match the path of the bin.

Comment out the one that does not apply to your install.

DAEMON=/usr/bin/mpd
#DAEMON=/usr/local/bin/mpd

Comment Pages:

Leave a Comment

Previous Post Next Post

RSS

Recent Posts

Categories

Meta